Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: bad formatting with CRLF line ending #41057

Closed
stamblerre opened this issue Aug 27, 2020 · 2 comments
Closed

x/tools/gopls: bad formatting with CRLF line ending #41057

stamblerre opened this issue Aug 27, 2020 · 2 comments
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Aug 27, 2020

Seems that this issue has come back - we need a proper way to test this.

Before:

package main

/*
Gronk description
*/
func Gronk() {
    d.New()
}

After:

package main

/*
Gronk description
*/
*/
func Gronk() {
    d.New()
}
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 2, 2020

Change https://golang.org/cl/252457 mentions this issue: internal/lsp: reproduce and fix golang/go#41057

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Sep 2, 2020

Filed an upstream issue: #41197.

myitcv added a commit to govim/govim that referenced this issue Sep 8, 2020
* internal/lsp/source: move completion to its own package acefd226
* internal/lsp/source: support some fzf-like tokens in symbol matching ea3a2cdb
* internal/lsp/analysis: update fillreturns title 242af255
* internal/lsp/source: fix go1.12 build (again) 9786fa37
* internal/lsp: add support for RelatedInformation in diagnostics 39188db5
* internal/lsp: support for package completion in all files 93eecc35
* gopls/internal/regtest: use gopls hooks and add a test for staticcheck af4cc2cd
* gopls/integration/regtest: move regtests to the gopls module e2cc5a11
* present: fix newline parsing for go present 76a6aac6
* playground/socket: remove the os cleanup from start method of process 2364a5e8
* internal/lsp: reproduce and fix golang/go#41057 cf788077
* internal/lsp/cache: use the right snapshot in ModUpgrade 36b1a880
* internal/lsp: clean up some of the mod code lens code 5d67d6c6
* go/ssa: implement missing testing.testDeps SetPanicOnExit0 method 5b9ef244
myitcv added a commit to govim/govim that referenced this issue Sep 9, 2020
* internal/lsp/source: move completion to its own package acefd226
* internal/lsp/source: support some fzf-like tokens in symbol matching ea3a2cdb
* internal/lsp/analysis: update fillreturns title 242af255
* internal/lsp/source: fix go1.12 build (again) 9786fa37
* internal/lsp: add support for RelatedInformation in diagnostics 39188db5
* internal/lsp: support for package completion in all files 93eecc35
* gopls/internal/regtest: use gopls hooks and add a test for staticcheck af4cc2cd
* gopls/integration/regtest: move regtests to the gopls module e2cc5a11
* present: fix newline parsing for go present 76a6aac6
* playground/socket: remove the os cleanup from start method of process 2364a5e8
* internal/lsp: reproduce and fix golang/go#41057 cf788077
* internal/lsp/cache: use the right snapshot in ModUpgrade 36b1a880
* internal/lsp: clean up some of the mod code lens code 5d67d6c6
* go/ssa: implement missing testing.testDeps SetPanicOnExit0 method 5b9ef244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.