Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: bad error messages when changing package names #41061

Open
stamblerre opened this issue Aug 27, 2020 · 4 comments
Open

x/tools/gopls: bad error messages when changing package names #41061

stamblerre opened this issue Aug 27, 2020 · 4 comments
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Aug 27, 2020

Repro case:

-- go.mod --
module mod.com
-- foo/foo.go --
package foo
-- foo/bar_test.go --
package foo_

Modifying foo/bar_test.go to contain package foo_test results in bad error messages (it doesn't recover from expecting that its name is foo_.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Aug 27, 2020
@stamblerre stamblerre added this to Bugs in gopls/v1.0.0 Aug 29, 2020
@pjweinb
Copy link

@pjweinb pjweinb commented Sep 6, 2020

Is this a duplicate of #38866?

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Sep 7, 2020

Possibly, but I think there are also issues with transitioning from a regular package to an x test.

@jadekler
Copy link
Contributor

@jadekler jadekler commented Sep 8, 2020

I've got a repro based on the above testcase, and will start taking a peek soon. Is anyone else working on this, though? Don't want to step on toes. =)

(if I hear nothing back I'll continue as if the answer to that is a "no")

@pjweinb
Copy link

@pjweinb pjweinb commented Sep 9, 2020

Go right ahead. i was going to look at #38866 but there's other things to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.