Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: ref/mod go.mod section has broken ids #41080

Closed
seankhliao opened this issue Aug 27, 2020 · 3 comments
Closed

x/website: ref/mod go.mod section has broken ids #41080

seankhliao opened this issue Aug 27, 2020 · 3 comments

Comments

@seankhliao
Copy link
Contributor

@seankhliao seankhliao commented Aug 27, 2020

What version of Go are you using (go version)?

current website

Does this issue reproduce with the latest release?

repros with https://tip.golang.org/ref/mod

What operating system and processor architecture are you using (go env)?

Google Chrome | 85.0.4183.83

What did you do?

visit https://golang.org/ref/mod and click on the require directive link in table of contents

What did you expect to see?

link/jump to "require directive" section

<h3 id="go.mod-require" class="mod-require"><code>require</code> directive</h3>

What did you see instead?

link/jump to "go.mod files" section

<h3 id="go" class="mod-require"><code>require</code> directive</h3>

additional info

it appears that the entire "go.mod files" section has their ids truncated to just go

@gopherbot gopherbot added this to the Unreleased milestone Aug 27, 2020
@seankhliao seankhliao changed the title x/website:ref/mod modfile directives have wrong id x/website: ref/mod go.mod section has broken ids Aug 27, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 31, 2020

Thanks for the report.

/cc @jayconrod

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Aug 31, 2020

CL 248617 fixes this.

@bcmills @matloob Please review 🥺

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 3, 2020

Change https://golang.org/cl/248617 mentions this issue: content/static/doc: fix anchors with dots in module documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.