Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: forward slash does not initiate find in page on Firefox #41093

Open
emilal opened this issue Aug 28, 2020 · 2 comments
Open

x/pkgsite: forward slash does not initiate find in page on Firefox #41093

emilal opened this issue Aug 28, 2020 · 2 comments

Comments

@emilal
Copy link

@emilal emilal commented Aug 28, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/k8s.io/client-go/kubernetes?tab=doc

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Screenshot

Screenshot_2020-08-28 kubernetes package · pkg go dev

What did you do?

Used the '/' key

What did you expect to see?

Firefox' "find in page"

What did you see instead?

Nothing. Something on the site seems to break '/' searching. (It was also broken on godoc.org, where it highlighted a search box that didn't search in the page.)

@gopherbot gopherbot added this to the Unreleased milestone Aug 28, 2020
@cagedmantis cagedmantis changed the title x/pkgsite: x/pkgsite: forward slash does not initiate find in page on Firefox Aug 28, 2020
@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Aug 28, 2020

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 1, 2020

Change https://golang.org/cl/252117 mentions this issue: content/static: fixes search input focus and supports quickfind in Firefox

gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 1, 2020
…refox

Fixes search input focus key on detail pages and removes the behavior
in Firefox to support quickfind.

Updates golang/go#41093

Change-Id: Iae0c8fdde0df592e7f9eeac37183b27231bb441c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/252117
Reviewed-by: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@gopherbot gopherbot added the go.dev label Sep 19, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.