cmd/compile: ambiguous TODO in ssa/html.go

[xiyichan]

What version of Go are you using (go version)?

$ go version
master

What did you do?

cmd/compile/internal/ssa/html.go:122

Use GOSSAFUNC to generate ssa.html.
This is the original state.

Is this hoping to be optimized like this?

Or other styles?

[randall77]

@bradford-hamilton

[ALTree]

The comment was introduced in afc480b.

[xiyichan]

Maybe not the letters are rotated 90 degrees. Could it be that the title is rotated 90 degrees?

[josharian]

See https://go-review.googlesource.com/c/go/+/226209/comment/d6b6d7d5_a01a22b1/. TL;DR: It'd better to use sideways-lr instead of vertical-lr, but it's not widely enough available: https://caniuse.com/#search=sideways-lr

[xiyichan]

See https://go-review.googlesource.com/c/go/+/226209/comment/d6b6d7d5_a01a22b1/. TL;DR: It'd better to use sideways-lr instead of vertical-lr, but it's not widely enough available: https://caniuse.com/#search=sideways-lr

ok，I try to use sideways-lr.but only firefox support this.

[bradford-hamilton]

See https://go-review.googlesource.com/c/go/+/226209/comment/d6b6d7d5_a01a22b1/. TL;DR: It'd better to use sideways-lr instead of vertical-lr, but it's not widely enough available: https://caniuse.com/#search=sideways-lr

ok，I try to use sideways-lr.but only firefox support this.

Hey, I think I'm seeing the confusion and sorry this is my fault... The comment should actually say 180 degrees. The original look that we wanted with sideways-lr reads from bottom to top & left to right (if I'm remembering correctly). @xiyichan does that help some?

[xiyichan]

See https://go-review.googlesource.com/c/go/+/226209/comment/d6b6d7d5_a01a22b1/. TL;DR: It'd better to use sideways-lr instead of vertical-lr, but it's not widely enough available: https://caniuse.com/#search=sideways-lr

ok，I try to use sideways-lr.but only firefox support this.

Hey, I think I'm seeing the confusion and sorry this is my fault... The comment should actually say 180 degrees. The original look that we wanted with sideways-lr reads from bottom to top & left to right (if I'm remembering correctly). @xiyichan does that help some?

yes, It should be rotated 180 degrees.I try to use other css to achieve.

[xiyichan]

See https://go-review.googlesource.com/c/go/+/226209/comment/d6b6d7d5_a01a22b1/. TL;DR: It'd better to use sideways-lr instead of vertical-lr, but it's not widely enough available: https://caniuse.com/#search=sideways-lr

ok，I try to use sideways-lr.but only firefox support this.

Hey, I think I'm seeing the confusion and sorry this is my fault... The comment should actually say 180 degrees. The original look that we wanted with sideways-lr reads from bottom to top & left to right (if I'm remembering correctly). @xiyichan does that help some?

yes, It should be rotated 180 degrees.I try to use other css to achieve.

like this?

[bradford-hamilton]

See https://go-review.googlesource.com/c/go/+/226209/comment/d6b6d7d5_a01a22b1/. TL;DR: It'd better to use sideways-lr instead of vertical-lr, but it's not widely enough available: https://caniuse.com/#search=sideways-lr

ok，I try to use sideways-lr.but only firefox support this.

Hey, I think I'm seeing the confusion and sorry this is my fault... The comment should actually say 180 degrees. The original look that we wanted with sideways-lr reads from bottom to top & left to right (if I'm remembering correctly). @xiyichan does that help some?

yes, It should be rotated 180 degrees.I try to use other css to achieve.

like this?

@xiyichan yes actually I think this is exactly what we wanted!

[xiyichan]

See https://go-review.googlesource.com/c/go/+/226209/comment/d6b6d7d5_a01a22b1/. TL;DR: It'd better to use sideways-lr instead of vertical-lr, but it's not widely enough available: https://caniuse.com/#search=sideways-lr

ok，I try to use sideways-lr.but only firefox support this.

Hey, I think I'm seeing the confusion and sorry this is my fault... The comment should actually say 180 degrees. The original look that we wanted with sideways-lr reads from bottom to top & left to right (if I'm remembering correctly). @xiyichan does that help some?

yes, It should be rotated 180 degrees.I try to use other css to achieve.

like this?

@xiyichan yes actually I think this is exactly what we wanted!

@bradford-hamilton ok,I will submit a CL.

[gopherbot]

Change https://golang.org/cl/251657 mentions this issue: cmd/compile:rotate phase's title 180 degrees in ssa/html.go