Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: several img tags lack descriptive alt text #41104

Closed
jba opened this issue Aug 28, 2020 · 3 comments
Closed

x/pkgsite: several img tags lack descriptive alt text #41104

jba opened this issue Aug 28, 2020 · 3 comments

Comments

@jba
Copy link
Contributor

@jba jba commented Aug 28, 2020

Current alt text says "Go" which is fine, but adds no semantic content for screen reader users. "Go logo" would be preferable.

@jba
Copy link
Contributor Author

@jba jba commented Aug 28, 2020

First comment applies to <img class=”NavigationDrawer-logo”> in header.

Also:

  • <img class=”Header-logo”> in header: use "Go logo"
  • <img class=”Footer-gopher”> in footer: use "Gopher in flight goggles"
@jba jba changed the title x/pkgsite: <img class=”NavigationDrawer-logo” in header lacks descriptive alt text x/pkgsite: several img tags lack descriptive alt text Aug 28, 2020
@jimmyfrasche
Copy link
Member

@jimmyfrasche jimmyfrasche commented Aug 28, 2020

.Header-logo and .NavigationDrawer-logo are the sole contents of links so the alt text should describe the destination of the link.

.Footer-gopher is purely decorative so its alt text should (explicitly) be the empty string.

@julieqiu julieqiu removed the UX label Sep 8, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 8, 2020

Change https://golang.org/cl/275938 mentions this issue: x/pgksite: several img tags lack descriptive alt text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants