Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: "failed to fetch any source profiles" in TestTimePprof #41120

Closed
bcmills opened this issue Aug 29, 2020 · 5 comments
Closed

runtime: "failed to fetch any source profiles" in TestTimePprof #41120

bcmills opened this issue Aug 29, 2020 · 5 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Aug 29, 2020

2020-08-28T21:23:32-a58a8d2/linux-amd64
2020-08-28T20:01:41-54e18f1/linux-amd64

There were two of these right in a row, and none with quite the same failure mode before today, so this looks like a possible 1.16 regression to me, possibly related to #41014.

CC @aclements @ianlancetaylor (via CL 97315)

@aclements
Copy link
Member

@aclements aclements commented Sep 17, 2020

It looks like the underlying problem here is that testprog TimeProf (the binary TestTimePprof runs) timed out. The "failed to fetch any source profiles" is a follow-on failure because the binary didn't exit. There's not much information about the time-out, unfortunately. We may want to add in a GOTRACEBACK=crash just to get more details.

@aclements
Copy link
Member

@aclements aclements commented Oct 1, 2020

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 1, 2020

Change https://golang.org/cl/258802 mentions this issue: runtime: add debugging to TestTimePprof

gopherbot pushed a commit that referenced this issue Oct 2, 2020
We've seen timeouts of TestTimePprof, but the tracebacks aren't useful
because goroutines are running on other threads. Add GOTRACEBACK=crash
to catch these in the future.

For #41120.

Change-Id: I97318172ef78d0cbab10df5e4ffcbfeadff579e3
Reviewed-on: https://go-review.googlesource.com/c/go/+/258802
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Oct 8, 2020

This hasn't been happening lately and seems that it shouldn't be blocking the release anymore.

We should update the issue if something changes.

@aclements
Copy link
Member

@aclements aclements commented Dec 22, 2020

According to greplogs -dashboard -e "failed to fetch any source profiles" -l, there haven't been any of these since 2020-09-03T05:33:35-6c76ede, so I'm calling this fixed.

@aclements aclements closed this Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants