Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: error and suggestion for tutorials pages #41150

Closed
yoshizzle opened this issue Aug 31, 2020 · 2 comments
Closed

x/website: error and suggestion for tutorials pages #41150

yoshizzle opened this issue Aug 31, 2020 · 2 comments

Comments

@yoshizzle
Copy link

@yoshizzle yoshizzle commented Aug 31, 2020

What version of Go are you using (go version)?

$ go version
1.15

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/josh/.cache/go-build"
GOENV="/home/josh/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/josh/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/josh/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/josh/projects/go/greetings/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build087138363=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I noticed two errors on the tutorial site:

  1. https://golang.org/doc/tutorial/call-module-code - Step 3, the line should read:

fmt.Println(message) and not (greeting)

  1. https://golang.org/doc/tutorial/handle-errors - Step 1, the "nil" being returned with "message" should probably be blue and bold to match the other new lines of code to be added.

What did you expect to see?

  1. message being printed instead of greeting
  2. bolding of new code

What did you see instead?

as reported above

@gopherbot gopherbot added this to the Unreleased milestone Aug 31, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Sep 1, 2020

Thanks for the report.

/cc @stevetraut

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 1, 2020

Change https://golang.org/cl/252077 mentions this issue: content/static/doc: fix error for tutorials pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.