Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: add tests for finding references in replace targets #41242

Open
stamblerre opened this issue Sep 6, 2020 · 1 comment
Open

x/tools/gopls: add tests for finding references in replace targets #41242

stamblerre opened this issue Sep 6, 2020 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@stamblerre
Copy link
Contributor

We don't have any tests for this behavior.
@stamblerre stamblerre added the Testing An issue that has been verified to require only test changes, not just a test failure. label Sep 6, 2020
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Sep 6, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 6, 2020
@adonovan
Copy link
Member

We still don't have any tests for this, but it's hard to imagine* references (and related features) × replace not working correctly, since architecturally they are so orthogonal.

*Clearly all these years of writing buggy code have not enlarged my imagination...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@adonovan @stamblerre @gopherbot