Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: show more search results per page or give users a setting for that #41245

Open
ainar-g opened this issue Sep 6, 2020 · 3 comments
Open

Comments

@ainar-g
Copy link
Contributor

@ainar-g ainar-g commented Sep 6, 2020

When looking for a module or a package, I will often find what I need on the second or the third page of the search results. There are already enough issues about the quality of the search, so for now I want to propose that the search show more results per page. I think, 100 results per page is a good number, but that may be too high and generate too much pressure on the search engine. But I don't know enough about it, so this is up to debate.

Perhaps there should also be an option for that, but if we go with 100 results per page by default, then I don't think anyone would need more. 100 is also a sane maximum value for such setting, in my opinion.

@gopherbot gopherbot added this to the Unreleased milestone Sep 6, 2020
@andybons
Copy link
Member

@andybons andybons commented Sep 8, 2020

Can you provide some examples of what you searched for and what the expected results were?

@ainar-g
Copy link
Contributor Author

@ainar-g ainar-g commented Sep 8, 2020

@andybons The case that made me file this issue? Sure! I wanted to share a working implementation of a 9P2000 server with a friend. I remembered, that I've successfully used the one made by Docker, but that was two or three years ago, so I didn't remember the package name. I looked up 9p server, and the first page didn't provide the one I was looking for, but the second page did. It was package github.com/docker/go-p9p.

There were some other cases before that, but I can't remember them now. I will add more later if something like that happens again.

Besides that particular case, I generally prefer long result lists, because with them I can then press Ctrl+F and filter them further. Kind of like a webpage equivalent of grep -e first -- file.txt | grep -e second.

@andybons
Copy link
Member

@andybons andybons commented Sep 9, 2020

That’s helpful. Thanks.

@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/search Sep 10, 2020
@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@gopherbot gopherbot added the go.dev label Sep 19, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.