Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regexp: add examples #4125

Closed
adg opened this issue Sep 21, 2012 · 7 comments
Closed

regexp: add examples #4125

adg opened this issue Sep 21, 2012 · 7 comments

Comments

@adg
Copy link
Contributor

@adg adg commented Sep 21, 2012

The regexp package could use some usage examples at the package level. There should be
at least one for each of Match, Find, and Replace.

It would also be good to demonstrate the use of SubexpNames.
@adg
Copy link
Contributor Author

@adg adg commented Sep 21, 2012

Comment 1:

Labels changed: added documentation, example.

@adg
Copy link
Contributor Author

@adg adg commented Oct 10, 2012

Comment 2:

Owner changed to ---.

@vdobler
Copy link
Contributor

@vdobler vdobler commented Nov 13, 2012

Comment 3:

Would a package level example be more helpful than individual
examples in the methods?  I tried to construct an package
level example but it is either very incomplete or long and
ugly.
How about examples for all the ...String... Methods of *Regexp
instead of a single package level example?
@adg
Copy link
Contributor Author

@adg adg commented Nov 13, 2012

Comment 4:

There can be multiple package-level examples, so we needn't try to pack everything into
a single top level example. We should certainly provide examples for the more
sophisticated parts of the package, but I think it's important to show the package's
general usage at the top level, too.
@adg
Copy link
Contributor Author

@adg adg commented Nov 14, 2012

Comment 5:

This issue was updated by revision e33b9f7.

R=golang-dev, r
CC=golang-dev
http://golang.org/cl/6846045
@rsc
Copy link
Contributor

@rsc rsc commented Nov 27, 2012

Comment 6:

This issue was updated by revision b46de71.

R=minux.ma, rsc
CC=golang-dev
http://golang.org/cl/6847107
Committer: Russ Cox 
@rsc
Copy link
Contributor

@rsc rsc commented Dec 10, 2012

Comment 7:

Looks like there are examples now.

Status changed to Fixed.

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.