Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add log statement to indicate gopls is serving #41282

Open
stamblerre opened this issue Sep 9, 2020 · 3 comments
Open

x/tools/gopls: add log statement to indicate gopls is serving #41282

stamblerre opened this issue Sep 9, 2020 · 3 comments

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Sep 9, 2020

Running gopls on the command-line directly currently defaults to serve mode, which is unhelpful for users of the CLI and unintuitive. We should add a log message indicating that gopls is serving and how to get help text.

@gopherbot gopherbot added this to the Unreleased milestone Sep 9, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Sep 9, 2020
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Oct 7, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2020

Change https://golang.org/cl/260008 mentions this issue: goLanguageServer: use gopls serveinstead of the defaultgopls``

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Nov 13, 2020

@findleyr and @ianthehat have discussed that most language servers do default to serve, but we can improve the UX by adding a log statement. So I will repurpose this issue to add a log statement indicating that gopls is serving.

@mattn
Copy link
Member

@mattn mattn commented Nov 14, 2020

FYI, as far as that I have looked over 70 language servers in my project https://github.com/mattn/vim-lsp-settings, most language server does not provide serve command.

@stamblerre stamblerre changed the title x/tools/gopls: move away from defaulting to serve command x/tools/gopls: add log statement to indicate gopls is serving Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants