Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: 'go list -m' should not require go.sum with -versions or when all args are version queries #41297

Open
jayconrod opened this issue Sep 9, 2020 · 2 comments
Labels
Milestone

Comments

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented Sep 9, 2020

What version of Go are you using (go version)?

$ go version
go version go1.15.1 darwin/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/jayconrod/Library/Caches/go-build"
GOENV="/Users/jayconrod/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/jayconrod/Code/modcache"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/jayconrod/go"
GOPRIVATE=""
GOPROXY="http://[::]:6123/mod"
GOROOT="/opt/go/installed"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/opt/go/installed/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/jayconrod/Code/test/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rq/x0692kqj6ml8cvrhcqh5bswc008xj1/T/go-build106221923=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

go mod init m
go mod edit -require=rsc.io/quote@v1.0.0
go list -m -mod=readonly -versions rsc.io/quote
go list -m -mod=readonly rsc.io/quote@latest

What did you expect to see?

Both the go list -m commands above should succeed.

What did you see instead?

Both commands fail. This happens because go list -m loads the build list before processing arguments. go.sum is missing, so that fails.

There's no need to load the build list for these commands. They both succeed when run outside a module or when go.mod contains no requirements.

@jayconrod jayconrod added this to the Backlog milestone Sep 9, 2020
@sibis
Copy link

@sibis sibis commented Sep 9, 2020

@jayconrod, Is this an up for grabs then? Because I'd like to try this one.

@jayconrod
Copy link
Contributor Author

@jayconrod jayconrod commented Sep 9, 2020

@sibis Sure, feel free to take a look. I think it can mostly be done in src/cmd/go/internal/list/list.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.