Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: "fatal error: unexpected signal during runtime execution" on windows-amd64-longtest builder of Go 1.15.2 commit [1.14 backport] #41322

Closed
dmitshur opened this issue Sep 10, 2020 · 5 comments

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Sep 10, 2020

@mknyszek requested issue #41296 to be considered for backport to the next 1.14 minor release.

@gopherbot Ple​ase open a backport issue for 1.14.

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Sep 10, 2020

Approved as this is a test fix, needed to reduce false-positives during pre-release testing. This backport applies to both 1.15 (#41317) and 1.14 (this issue).

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 10, 2020

Change https://golang.org/cl/253922 mentions this issue: [release-branch.go1.14] runtime: fix ReadMemStatsSlow's and CheckScavengedBits' chunk iteration

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Sep 10, 2020

Ah, thank you! I'm sorry for not getting to it sooner.

@dmitshur
Copy link
Member Author

@dmitshur dmitshur commented Sep 10, 2020

@mknyszek Not a problem!

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 10, 2020

Closed by merging 3b364d9 to release-branch.go1.14.

@gopherbot gopherbot closed this Sep 10, 2020
gopherbot pushed a commit that referenced this issue Sep 10, 2020
…engedBits' chunk iteration

Both ReadMemStatsSlow and CheckScavengedBits iterate over the page
allocator's chunks but don't actually check if they exist. During the
development process the chunks index became sparse, so now this was a
possibility. If the runtime tests' heap is sparse we might end up
segfaulting in either one of these functions, though this will generally
be very rare.

The pattern here to return nil for a nonexistent chunk is also useful
elsewhere, so this change introduces tryChunkOf which won't throw, but
might return nil. It also updates the documentation of chunkOf.

For #41296.
Fixes #41322.

Change-Id: Id5ae0ca3234480de1724fdf2e3677eeedcf76fa0
Reviewed-on: https://go-review.googlesource.com/c/go/+/253777
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 34835df)
Reviewed-on: https://go-review.googlesource.com/c/go/+/253922
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.