-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: Stick to the preferred package version #41325
Comments
I might have spoken too early. It seems like the problem isn't that links aren't versioned, but rather that Would you provide both as an option? If so, how? |
Hmm, the development branches are inherently not stable so users won't expect to have stability when browsing branches. Not being able to use the package site during development is a more major issue in our case. |
Pehraps GitHub's model could be copied here. The links are as-is by default, e.g. Though I have to say that such a default worries me a little bit. Far too often people share GitHub links with just "master" as the ref, which tends to break over time. Especially now that many projects are renaming their master branch :) |
I have one more idea but not sure if it's a good one. Development-time package serving can a separate service clearly indicating that it's not the stable thing. |
Another way to implement that could be just a URL query parameter like |
When browsing packages at a particular version, for example master, the package site doesn't stick to the version.
For example, on https://pkg.go.dev/go.opentelemetry.io/otel@master/api/trace?tab=doc the links are not generated for the master branch. When I click on "subdirectories", it takes me to https://pkg.go.dev/go.opentelemetry.io/otel@v0.11.1-0.20200909181337-06689a01bd02/api/trace?tab=subdirectories.
This makes package site not a viable option during development. Please stick to the preferred version if possible to improve this issue.
The text was updated successfully, but these errors were encountered: