Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: creates many /tmp/go-build* directories #41331

Open
OneOfOne opened this issue Sep 11, 2020 · 4 comments
Open

x/tools/gopls: creates many /tmp/go-build* directories #41331

OneOfOne opened this issue Sep 11, 2020 · 4 comments

Comments

@OneOfOne
Copy link
Contributor

@OneOfOne OneOfOne commented Sep 11, 2020

This is a dup of #37368, it was never fixed for me, I still end up with a few (mostly empty) /tmp/go-build* folders.

I can reproduce with current release, master and my ghetto rebased master on top of dev.go2go.

$ ls /tmp/go-build* | wc -l
2874
$ find /tmp/go-build* -type f | wc -l
261
$ ● find /tmp/go-build* -type f | tail -n 6
/tmp/go-build969177635/b001/exe/a.out
/tmp/go-build969177635/b001/importcfg.link
/tmp/go-build992265488/b001/exe/a.out
/tmp/go-build992265488/b001/importcfg.link
/tmp/go-build996176431/b001/exe/a.out
/tmp/go-build996176431/b001/importcfg.link
@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2020
@OneOfOne
Copy link
Contributor Author

@OneOfOne OneOfOne commented Sep 11, 2020

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Sep 11, 2020

/cc @heschik

@stamblerre stamblerre removed this from the Unreleased milestone Sep 11, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
@OneOfOne
Copy link
Contributor Author

@OneOfOne OneOfOne commented Mar 16, 2021

This is still an issue, both latest release and latest master.

● ls /tmp/ | grep go-b
go-build1081835929/
go-build2583266889/
go-build293315992/
go-build3386006498/

@heschi
Copy link
Contributor

@heschi heschi commented Mar 16, 2021

I think I had at some point suspected that this was a bug in the go command: it needs to call base.Exit for https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/work/action.go;l=273-293 to fire, and it's not totally obvious to me that it does on all code paths. But I'm not sure. I don't know how to investigate this further offhand.

I guess I can just crank the current 1-second delay up and hope that it's a timing problem.

@bcmills @jayconrod @matloob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants