Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: broken debug pages #41343

Open
findleyr opened this issue Sep 11, 2020 · 0 comments
Open

x/tools/gopls: broken debug pages #41343

findleyr opened this issue Sep 11, 2020 · 0 comments

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented Sep 11, 2020

Our debug pages were broken by https://golang.org/cl/245058. Sample error: template: :8:49: executing "body" at <.Identity>: can't evaluate field Identity in type source.Overlay.

Clearly these are not widely used as they have been broken for over a month without anyone noticing, but they can be very useful. We should fix them and add a regtest that all of our debug templates render.

cc @heschik @ianthehat @stamblerre

@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Sep 11, 2020
@stamblerre stamblerre added this to Bugs in gopls/v1.0.0 Sep 16, 2020
@stamblerre stamblerre added the NeedsFix label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.