Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: new major version not surfaced when it does not yet have a release tag #41345

Closed
tbpg opened this issue Sep 11, 2020 · 5 comments
Closed

Comments

@tbpg
Copy link
Contributor

@tbpg tbpg commented Sep 11, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/gopkg.in/yaml.v3?tab=doc

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.83 Safari/537.36

Screenshot

yaml

What did you do?

  1. Searched for yaml on pkg.go.dev: https://pkg.go.dev/search?q=yaml
  2. Saw "v3" near the top, so I assumed it was the latest.
    image

What did you expect to see?

A clear explanation of what version I should use.

What did you see instead?

I didn't expect v3 to be so high if v2 is the latest. Also, v3 is a later SemVer, but pkg.go.dev says v2 is the latest SemVer. Also, the v3 version was published Jun 15, 2020 while v2 was released May 6, 2020.

cc @julieqiu

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Sep 11, 2020

@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@julieqiu julieqiu changed the title x/pkgsite: gopkg.in/yaml.v3 confusingly says /v2 is the latest x/pkgsite: new major version not surfaced when it does not yet have a release tag Sep 21, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Sep 23, 2020

Thanks for the feedback!

We're going to make these changes to pages like this:

  • The banner message will say "The latest major version is v3. The latest major version with tagged releases is v2."
  • The versions tab will list the v3 module, with the message "No tagged versions in this module."

Here's a mock:
image

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 4, 2020

Change https://golang.org/cl/266141 mentions this issue: content: add text to versions tab when tagged version is missing

gopherbot pushed a commit to golang/pkgsite that referenced this issue Nov 4, 2020
When a series has tagged versions, but the current module version does
not, the versions tab will now display the message "No tagged versions in
this module." instead of displaying nothing.

For golang/go#41345

Change-Id: I2137187532bce18d1c60bc7aa138e14a6fb7e559
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/266141
Trust: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Nov 4, 2020

This will be fixed in the next deploy.

Here's the updated UI for the current site:

image

And on the redesign site at https://beta.pkg.go.dev:

image

@julieqiu julieqiu closed this Nov 4, 2020
@tbpg
Copy link
Contributor Author

@tbpg tbpg commented Nov 9, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants