Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: proposal: add link on Not Found page #41347

Closed
fgergo opened this issue Sep 11, 2020 · 5 comments
Closed

x/pkgsite: proposal: add link on Not Found page #41347

fgergo opened this issue Sep 11, 2020 · 5 comments

Comments

@fgergo
Copy link

@fgergo fgergo commented Sep 11, 2020

https://pkg.go.dev/nosuchpackage returns "404 Not Found" as it should.
I'd propose to add a link below the error message, something like this:
Add a package to pkg.go.dev.

background: #41318

@gopherbot gopherbot added this to the Unreleased milestone Sep 11, 2020
@seankhliao
Copy link
Contributor

@seankhliao seankhliao commented Sep 11, 2020

the functionality exists when you use a proper package path, ex: https://pkg.go.dev/github.com/nosuch/package

@fgergo
Copy link
Author

@fgergo fgergo commented Sep 11, 2020

@seankhliao You probably misunderstood the proposal.
Please take a look again at the proposed link and maybe have a look at #41318 .

@seankhliao
Copy link
Contributor

@seankhliao seankhliao commented Sep 11, 2020

This is what I see right now: a button with "Request " (you may have to use a not negatively cached url).
Does this not do what your proposal covers?
2020-09-12-002712

@fgergo
Copy link
Author

@fgergo fgergo commented Sep 11, 2020

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 15, 2020

Change https://golang.org/cl/255097 mentions this issue: content/static/html/pages: link to package-adding instructions on 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants