Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: TryBots don't complain about not gofmt code in the package #41352

Closed
alexbrainman opened this issue Sep 12, 2020 · 2 comments
Closed

all: TryBots don't complain about not gofmt code in the package #41352

alexbrainman opened this issue Sep 12, 2020 · 2 comments

Comments

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Sep 12, 2020

I was doing codereview of

https://go-review.googlesource.com/c/go/+/250077

and discovered that patch set 2 was not gofmted, but TryBot did not complain about it.

I have asked CL author to gofmt his code. Is that something should be enforced by TryBots automatically? Maybe have a test that verifies that all appropriate code is gofmted.

Maybe it is OK to submit un formatted code. Feel free to close this issue then.

Thank you.

Alex

@tklauser
Copy link
Member

@tklauser tklauser commented Sep 14, 2020

Also see #18548 which proposes something similar with additional checks (e.g. copyright headers).

@alexbrainman
Copy link
Member Author

@alexbrainman alexbrainman commented Sep 15, 2020

Thanks @tklauser for the reference. It does indeed looks like a duplicate. So closing my issue.

Mind you, given #18548 is nearly 3 years old, does not give me much confidence. :-)

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.