-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gollvm: cmd/go: httpguts, hpack, idna are not using a known version control system #41368
Comments
None at all, I don't even use go 🤔 Maybe you meant to tag someone else? 😅 |
CC @thanm @cherrymui Do you have any |
|
https://github.com/streamsets/datacollector-edge project does not contain any go.mod file. |
I took a look at this -- I can reproduce, but I don't have any insight into what's going wrong. I don't see any replace directives at least as far as I can tell. |
I don't think this is related to modules. This error would be reported in GOPATH mode if a repository root path resolves to a directory in Does the directory |
Does the directory $GOPATH/src/golang.org/x/net/.git exist? Yes, $GOPATH/src/golang.org/x/net/.git exists. What about $GOPATH/src/golang.org/x/net/http/httpguts/.git? No, that does not exist. |
Those three packages are vendored into the standard library: Lines 14 to 17 in 86dbeef
So probably this has something to do with standard-library vendoring in |
Yeah, that |
@bcmills , so what should be patched? |
@advancedwebdeveloper, that depends on what the root cause turns out to be. 😅 Could you run |
@jayconrod , $GOPATH is not defined (for some reason) - and that a "by default" state, since I have installed compiled "release" build of gollvm. But a de-facto directory does exist:
Well, in case of this file - neither de-facto nor relative path/fiel exists:
Ivan |
@bcmills , |
Surely I am able to do that:
dir. does not exist
same here. Ivan |
Change https://golang.org/cl/256319 mentions this issue: |
Change https://golang.org/cl/256362 mentions this issue: |
This ensures that internal/goroot.IsStandardPackage does not treat golang.org packages as being in the standard library. For golang/go#41368 Fixes golang/go#41499 Change-Id: I58abc84c6c8544b3d7f513bda7a5e5a63d0a9937 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/256319 Trust: Ian Lance Taylor <iant@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: Than McIntosh <thanm@google.com>
This ensures that internal/goroot.IsStandardPackage does not treat golang.org packages as being in the standard library. For golang/go#41368 Fixes golang/go#41499 Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/256319
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
I was trying to get StreamSets Data Collector Edge working.
What did you expect to see?
At least - no warning or errors.
What did you see instead?
@bradfitz, @FiloSottile , @alanbato, @mpvl - any suggestions?
Ivan
The text was updated successfully, but these errors were encountered: