Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: http2 healthcheck not in h2_bundle.go #41375

Open
phiphi282 opened this issue Sep 14, 2020 · 5 comments
Open

x/net/http2: http2 healthcheck not in h2_bundle.go #41375

phiphi282 opened this issue Sep 14, 2020 · 5 comments

Comments

@phiphi282
Copy link

@phiphi282 phiphi282 commented Sep 14, 2020

What version of Go are you using (go version)?

$ go version go1.15.1

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
not important

What did you do?

Inspected the h2_bundle.go to see how it was generated. Error not really reproducible with code.
Inspected this file: https://github.com/golang/go/blob/go1.15.2/src/net/http/h2_bundle.go

What did you expect to see?

Expected commit golang/net@0ba52f6 to be bundled into 1.15.x because the commit exists in the release-branch.go1.15 branch.

What did you see instead?

The commit apparently didn't get bundled into 1.15 release.

@AlexRouSg
Copy link
Contributor

@AlexRouSg AlexRouSg commented Sep 14, 2020

You are mistaking the golang/net branch to mean it's included in the golang/go standard library. golang/net refers to the golang.org/x/net package

For golang/go there is a commit pulling in the changes but it was done after 1.15 and was not backorted so it looks like it will be in the standard library in 1.16 3d77461

@phiphi282
Copy link
Author

@phiphi282 phiphi282 commented Sep 14, 2020

I understood the the golang/net repo refers to golang.org/x/net but I am not yet sure about what the branches are for. From the name release-branch.go1.x it sound very much like it is the branch used in the respective minor version.

Otherwise I don't know what the branches are for.

Additionally there is even a reference to the commit I was asking about in the go.mod update commit https://go-review.googlesource.com/c/net/+/198040/.

@AlexRouSg
Copy link
Contributor

@AlexRouSg AlexRouSg commented Sep 14, 2020

cc @odeke-em for questions relating to golang/net

@toothrot toothrot changed the title x/net/http2 http2 healthcheck not in h2_bundle.go x/net/http2: http2 healthcheck not in h2_bundle.go Sep 15, 2020
@toothrot
Copy link
Contributor

@toothrot toothrot commented Sep 15, 2020

The x/ repo branches represent what exists in the Go repo go.mod at the time of cutting a release. This is necessary for us to be able to backport issues to x repositories during a release.

Bundles are a different story. I am not sure why h2_bundle.go wasn't updated when the net repo was most recently updated in the Go 1.15 cycle in https://golang.org/cl/241257, or when it is supposed to be.

Perhaps @bcmills, @odeke-em or @dmitshur knows more, as they have recently discussed this in the commit that @phiphi282 mentioned.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Sep 15, 2020

My understanding is that the bundled version and vendored version are currently specified independently. The bundled version wasn't updated to the same version as in src/go.mod for the Go 1.15 release, which is why that particular change isn't there.

I think this issue still exists on the main branch, I filed #41409 for that. We probably need to get to a resolution there before thinking about what, if anything, should to be done for 1.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.