Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: A11y "Previous" button on first results page implemented properly but confusing #41380

Open
kmstorer opened this issue Sep 14, 2020 · 1 comment
Labels
NeedsInvestigation pkgsite/frontend pkgsite

Comments

@kmstorer
Copy link

@kmstorer kmstorer commented Sep 14, 2020

What version of Go are you using (go version)?

NA

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
NA

What did you do?

On first page of Results page, "Previous" button in pagination section top right is present but deemphasized. This is technically implemented correctly. But, it is disorienting for screen reader users for whom the feedback is not persistent.

What did you expect to see?

Proposal: Remove "Previous" from pagination on 1st results page, as there is no previous page.

What did you see instead?

@toothrot toothrot changed the title A11y "Previous" button on first results page implemented properly but confusing x/pkgsite: A11y "Previous" button on first results page implemented properly but confusing Sep 15, 2020
@gopherbot gopherbot added this to the Unreleased milestone Sep 15, 2020
@toothrot
Copy link
Contributor

@toothrot toothrot commented Sep 15, 2020

It is my understanding that keeping the controls consistent between pages is the best practice, and correctly labeling the "previous" button on the first page as aria-disabled. I could be mistaken, though! Do you mind letting me know which screen reader are you using?

@toothrot toothrot added the NeedsInvestigation label Sep 15, 2020
@julieqiu julieqiu added pkgsite and removed website labels Sep 19, 2020
@julieqiu julieqiu removed the website label Sep 19, 2020
@jba jba removed this from the Unreleased milestone Sep 19, 2020
@jba jba added this to the pkgsite/frontend milestone Sep 19, 2020
@hyangah hyangah added the pkgsite/frontend label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation pkgsite/frontend pkgsite
Projects
None yet
Development

No branches or pull requests

6 participants