Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: add "Package files" section for commands #41396

Open
LeGEC opened this issue Sep 15, 2020 · 1 comment
Open

x/pkgsite: add "Package files" section for commands #41396

LeGEC opened this issue Sep 15, 2020 · 1 comment

Comments

@LeGEC
Copy link

@LeGEC LeGEC commented Sep 15, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/google/gopacket/examples/httpassembly?tab=doc

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Screenshot

not relevant

What did you do?

Just went to the doc page for this package

What did you expect to see?

A Package files section, with links to the underlying code files, as the former godoc.org site would offer :

https://godoc.org/github.com/google/gopacket/examples/httpassembly?tab=doc
has a main.go link, which leads to :
https://github.com/google/gopacket/blob/master/examples/httpassembly/main.go

What did you see instead?

I found no such link, in none of the tabs of the pkg.go.dev version for this url.


In this specific case, there is no public symbol to "document", and the documentation clearly implies "go read the code of the main function", so the lack of Package files section is particularly emphasized here.

@gopherbot gopherbot added this to the Unreleased milestone Sep 15, 2020
@julieqiu julieqiu added pkgsite and removed go.dev labels Sep 19, 2020
@gopherbot gopherbot added the go.dev label Sep 19, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@jba
Copy link
Contributor

@jba jba commented Sep 19, 2020

We'll be adding a Package Files section soon.

@jba jba modified the milestones: Unreleased, pkgsite/design-2020 Sep 19, 2020
@julieqiu julieqiu changed the title x/pkgsite: no 'Package files' links x/pkgsite: add "Package files" section for commands Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.