Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: consider hardcoding RSA PSS paramemters #41407

Closed
rolandshoemaker opened this issue Sep 15, 2020 · 1 comment
Closed

crypto/x509: consider hardcoding RSA PSS paramemters #41407

rolandshoemaker opened this issue Sep 15, 2020 · 1 comment
Labels
Milestone

Comments

@rolandshoemaker
Copy link
Member

@rolandshoemaker rolandshoemaker commented Sep 15, 2020

rsaPSSParameters is used to generate the RSA PSS parameters based on a given hash. It constructs a structure based on the hash and marshals it using encoding/asn1. Given there are only three possible input hashes it's somewhat heavyweight for what it does, and could be replaced by hardcoding the three possible DER parameter encodings that can be generated and picking one based on the hash.

This would also simplify the necessity for error handling that comes with calling asn1.Marshal (see https://go-review.googlesource.com/c/go/+/252557/).

@rolandshoemaker rolandshoemaker added this to the Unplanned milestone Sep 15, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 28, 2020

Change https://golang.org/cl/258037 mentions this issue: crypto/x509: hardcode RSA PSS parameters rather than generating them

@gopherbot gopherbot closed this in f33263d Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.