Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: h2_bundle.go (and socks_bundle.go) can get out of sync with src/go.mod's x/net version #41409

Open
dmitshur opened this issue Sep 15, 2020 · 3 comments
Milestone

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Sep 15, 2020

We've had issues in the past where version skew could be introduced if people forgot to update a one part of the distribution without also updating another (e.g., versions in src/go.mod and src/cmd/go.mod). A very effective solution was adding a test that fails when skew is detected.

I believe we still need to address this for net/http's bundled copies of golang.org/x/net/http2 and golang.org/x/net/internal/socks. Right now, it's possible to update the bundled copy independently from the src/go.mod version, but it's not clear that flexibility is something we want to keep.

See #41375 where this came up. Also relevant is #25285.

I plan to revisit my review of CL 189818 (which fixes issue #32031), the trade-offs have changed by now (especially given #41330).

/cc @toothrot @bcmills @FiloSottile

@dmitshur dmitshur added this to the Go1.16 milestone Sep 15, 2020
@dmitshur dmitshur changed the title net/http: h2_bundle.go (and socks_bundle.go) can get out of sync with src/go.mod's x/net/http2 version net/http: h2_bundle.go (and socks_bundle.go) can get out of sync with src/go.mod's x/net version Sep 15, 2020
@bcmills
Copy link
Member

@bcmills bcmills commented Sep 15, 2020

#36852 is also related: ideally the TryBot should flag any CL that causes the selected version of x/net/http2 to diverge from the version from which h2_bundle.go was generated.

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 18, 2020

Change https://golang.org/cl/255859 mentions this issue: misc/update: add program to update golang.org/x dependencies

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 21, 2020

Change https://golang.org/cl/256357 mentions this issue: cmd/updatestd: add program to maintain standard library modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.