Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: executeCommand failures should be clearly shown to the user #41413

Closed
stamblerre opened this issue Sep 16, 2020 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Sep 16, 2020

I just ran extract to function and it failed silently. Any command failure should be shown to the user via a ShowMessage.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Sep 16, 2020
@findleyr findleyr self-assigned this Sep 16, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 16, 2020

Change https://golang.org/cl/255128 mentions this issue: internal/lsp: always show errors from running commands

@stamblerre stamblerre added this to Bugs in gopls/v1.0.0 Sep 16, 2020
gopls/v1.0.0 automation moved this from Bugs to Closed Sep 17, 2020
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.5.1 Sep 17, 2020
@stamblerre stamblerre removed this from Closed in gopls/v1.0.0 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.