Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: executeCommand failures should be clearly shown to the user #41413

stamblerre opened this issue Sep 16, 2020 · 1 comment


Copy link

@stamblerre stamblerre commented Sep 16, 2020

I just ran extract to function and it failed silently. Any command failure should be shown to the user via a ShowMessage.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Sep 16, 2020
@findleyr findleyr self-assigned this Sep 16, 2020
Copy link

@gopherbot gopherbot commented Sep 16, 2020

Change mentions this issue: internal/lsp: always show errors from running commands

@gopherbot gopherbot closed this in 60aba8a Sep 17, 2020
@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Sep 17, 2020
@stamblerre stamblerre added this to the gopls/v0.5.1 milestone Sep 17, 2020
@golang golang locked and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants