Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: cache panic inheriting destroyed handle #41415
Just got a concerning panic from the generational cache:
This is running in daemon mode. I'm sure this is less likely to occur in standalone mode.
Logs were not revealing, but I have them if we think they'd be useful.
Perhaps a reasonable action would be to improve the error message above to make this easier to diagnose.
I'm very open to suggestions on how to improve the error message, but this is fundamentally very tricky stuff :-/
Did this happen as you exited an editor? My best guess is that we tried to deal with a
Any metadata describing the handle would be a start. Given how few distinct handles we have, perhaps this could be threaded through.
From our analysis, we think this was in the s.packages loop of
gopls uses a lot of keys that are just strings, which print without any type information. Include the type of the key explicitly. Updates golang/go#41415. Change-Id: I01cfc685184e7b44c1f562b6536f173da5ae4830 Reviewed-on: https://go-review.googlesource.com/c/tools/+/255357 Trust: Heschi Kreinick <firstname.lastname@example.org> Reviewed-by: Robert Findley <email@example.com>