You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the attention! The standalone server calls ServeConn directly with a connection wrapped in ALTS. I was thinking if serverInternalState is public, users can call StartGracefulShutdown() directly, instead of implementing their own. Thanks!
Its not so simple. Regardless of where we could put StartGracefulShutdown(), the current code lacks most of the guards that are currently provided via http.Server. One such example is preventing new connections from being served once Shutdown is called. Exposing the current shutdown behavior just affects the current connections but does nothing to prevent new ones.
That's right! I totally agree that to implement a complete graceful shutdown, there would be much more work.
But for the standalone use case, it would be relatively easy for users to close listeners and make sure the server waits for existing connections to close. The hard/impossible part is to trigger GOAWAYs (Please correct me if I am wrong). startGracefulShutdown() does exactly that. Instead of calling it StartGracefulShutdown(), we could call it SendGracefulGoawayOnActiveConnections(). What do you think? Thanks!