Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Remove 2 modules #41439

Closed
davidsbond opened this issue Sep 16, 2020 · 5 comments
Closed

x/pkgsite: Remove 2 modules #41439

davidsbond opened this issue Sep 16, 2020 · 5 comments
Assignees
Labels

Comments

@davidsbond
Copy link
Contributor

@davidsbond davidsbond commented Sep 16, 2020

Hello, I've been fiddling around with vanity import paths and have accidentally merged some modules together I didn't intend to.

Could these modules be removed in their entirety please?
https://pkg.go.dev/pkg.dsb.dev/bimpsonbot
https://pkg.go.dev/pkg.dsb.dev/eventsource

Thank you

@gopherbot gopherbot added this to the Unreleased milestone Sep 16, 2020
@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@gopherbot gopherbot added the go.dev label Sep 19, 2020
@julieqiu julieqiu added pkgsite and removed go.dev labels Sep 19, 2020
@jba jba self-assigned this Sep 19, 2020
@jba jba modified the milestones: Unreleased, pkgsite/licenses Sep 19, 2020
@jba jba added NeedsFix and removed NeedsInvestigation labels Sep 19, 2020
@julieqiu julieqiu removed this from the pkgsite/licenses milestone Sep 21, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Sep 21, 2020

Done.

@julieqiu julieqiu closed this Sep 21, 2020
@davidsbond
Copy link
Contributor Author

@davidsbond davidsbond commented Sep 21, 2020

Thanks @julieqiu,

I noticed I can still see them at the bottom of the list here:

https://pkg.go.dev/pkg.dsb.dev

Will those go away once I've done a new version of the pkg.dsb.dev module?

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Sep 21, 2020

They've been deleted.

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 21, 2020

Change https://golang.org/cl/256306 mentions this issue: internal/postgres: check for excluded in GetNestedModules

@davidsbond
Copy link
Contributor Author

@davidsbond davidsbond commented Sep 21, 2020

Perfect, thank you very much :)

gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 21, 2020
When a module path is excluded, we shouldn't display it on the
subdirectories table.

For golang/go#41439

Change-Id: I2033cea50c7957e5dbc98195fed6a54a727866ff
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/256306
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Trust: Julie Qiu <julie@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants