Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: install instructions for macOS/Windows target .pkg/.msi downloads, but are not applicable for .tar.gz/.zip archives #41441

Open
kevinburkemeter opened this issue Sep 17, 2020 · 3 comments
Labels
Milestone

Comments

@kevinburkemeter
Copy link

@kevinburkemeter kevinburkemeter commented Sep 17, 2020

If I visit this URL: https://golang.org/doc/install?download=go1.15.2.darwin-amd64.tar.gz

I see instructions that read:

Open the package file you downloaded and follow the prompts to install Go.

The package installs the Go distribution to /usr/local/go. The package should put the /usr/local/go/bin directory in your PATH environment variable. You may need to restart any open Terminal sessions for the change to take effect.

This is incorrect for the tar.gz file, which when clicked on creates a "go" directory in the same parent directory as wherever the tarball was downloaded (usually ~/Downloads on a Mac).

We should probably instead instruct people to move the go folder to /usr/local or somewhere else on their PATH.

@gopherbot gopherbot added this to the Unreleased milestone Sep 17, 2020
@toothrot
Copy link
Contributor

@toothrot toothrot commented Sep 18, 2020

/cc @dmitshur

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Sep 18, 2020

Thanks for reporting. This seems to also apply to Windows. It's possible to select a zip (e.g., go1.15.2.windows-amd64.zip) at https://golang.org/dl/, but the https://golang.org/doc/install#install section on the redirected page begins with "Open the MSI file you downloaded ...".

It seems that the zip/tar.gz files are not taken into account on that page at this time.

/cc @stevetraut

@dmitshur dmitshur changed the title x/website: instructions are incorrect for tar.gz download x/website: install instructions for macOS/Windows target .pkg/.msi downloads, but are not applicable for .tar.gz/.zip archives Sep 18, 2020
@kevinburkemeter
Copy link
Author

@kevinburkemeter kevinburkemeter commented Sep 28, 2020

I'm happy to take a stab at fixing this, but note it is difficult to view/test changes locally because I get redirected from localhost:6060/doc/install to golang.org/dl.

I have a CL that makes it possible to view this page locally, which would make it easier to change. https://go-review.googlesource.com/c/website/+/254538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.