Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: support dynamic configuration #41483

Open
jba opened this issue Sep 18, 2020 · 4 comments
Open

x/pkgsite: support dynamic configuration #41483

jba opened this issue Sep 18, 2020 · 4 comments
Assignees
Labels

Comments

@jba
Copy link
Contributor

@jba jba commented Sep 18, 2020

Support configuration loaded periodically from a source other than the database, such as a file in a storage system like GCS.

The first use will be for experiments.

By moving away from the DB for this information, we can enforce DevOps policies more easily, and allow two frontends with different experiment setups to share the same DB.

@jba jba added this to the pkgsite/unplanned milestone Sep 18, 2020
@jba jba self-assigned this Sep 18, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 18, 2020

Change https://golang.org/cl/256017 mentions this issue: internal/config: support env var for bucket

gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 18, 2020
The GCS bucket for overrides can now be configured with an environment
variable.

For golang/go#41483

Change-Id: Iba9f83afd7bc658d89d21f9d5ce693bbd142cb25
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/256017
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 18, 2020

Change https://golang.org/cl/256018 mentions this issue: internal/config: support dynamic config

@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@gopherbot gopherbot added the go.dev label Sep 19, 2020
@julieqiu julieqiu removed the go.dev label Sep 19, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 21, 2020

Change https://golang.org/cl/256238 mentions this issue: middleware: report error to GCP on experiment load failure

gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 21, 2020
Add support for "dynamic" configuration, meaning that the config is
not tied to deployment. It is read from a (statically!) configured GCS
object, and can be re-read at any time.

This CL defines the DynamicConfig struct and provides code to read and
parse it.  (Reading and parsing are provided as separate exported
functions to support checking by a separate tool.) Later CLs will hook
it up to the experiments framework.

For golang/go#41483

Change-Id: Ic37fdfe9e11682d60e9b8863a79ddf73db3f20fc
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/256018
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 21, 2020
If experiments can't be loaded, send the error to GCP's error
reporting service. This can be used to alert that there is a
problem with the experiment configuration.

For golang/go#41483

Change-Id: Ia4fd9047dafd2ddd3d1bce46d1acd26ee00b7113
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/256238
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 21, 2020

Change https://golang.org/cl/256380 mentions this issue: internal/cmdconfig: use dynamic config for experiments on env var

gopherbot pushed a commit to golang/pkgsite that referenced this issue Sep 21, 2020
If the GO_DISCOVERY_EXPERIMENTS_FROM_CONFIG env var is "true", read
experiments from dynamic config instead of the database.

Temporary, until we switch over completely to dynamic config.

For golang/go#41483

Change-Id: Icf6038fb9f2322eba24bedf60450cd9fce84bd6c
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/256380
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.