Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: deep completion misranked #41489

Closed
muirdm opened this issue Sep 18, 2020 · 4 comments
Closed

x/tools/gopls: deep completion misranked #41489

muirdm opened this issue Sep 18, 2020 · 4 comments
Labels
Milestone

Comments

@muirdm
Copy link

@muirdm muirdm commented Sep 18, 2020

See below screenshot. I expect &bytes.Buffer{} to be the first candidate, but for some reason packages are winning.

Screen Shot 2020-09-18 at 2 29 38 PM

@gopherbot gopherbot added this to the Unreleased milestone Sep 18, 2020
@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Sep 18, 2020

@muirdm: This is with gopls at master (and the deep completion CL), I assume?

/cc @heschik @dandua98

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.1 Sep 18, 2020
@muirdm
Copy link
Author

@muirdm muirdm commented Sep 18, 2020

This is with gopls at master (and the deep completion CL), I assume?

Yes, master at e94ab72881893c257f5cecf9e0ed1b9d5c72f6e7. I've been noticing it for a while, though.

@dandua98
Copy link

@dandua98 dandua98 commented Sep 18, 2020

Was not able to reproduce on master, strange. Seem to be ordered as expected for me. The order is actually reversed for you. Is this with vscode-go? I'm wondering if it's the client side implementation.

image

@muirdm
Copy link
Author

@muirdm muirdm commented Sep 19, 2020

It seems my editor has suddenly started changing the order of candidates for some reason 😠 . Sorry!

@muirdm muirdm closed this Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.