Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/website: Incorrect tar instructions for Linux download #41528
It seems that the code to generate the CLI for the file that was downloaded is wrong and using a possibly hard coded version number.
When a user downloads the file, the instructions should return the instructions to install/unpack the file.
What did you do?
Downloaded Go 1.15.2
What did you expect to see?
tar -C /usr/local -xzf go1.15.2.linux-amd64.tar.gz
What did you see instead?
tar -C /usr/local -xzf go1.14.3.linux-amd64.tar.gz
I'm not sure how CI/CD works for different regions for the website, but the next day my fix got approved-merged it had been deployed and I've seen it working.
NVM, looks like your issue is valid and it's not because of the deployment.
Updated "detectOS" function to use "userAgent" instead of "appVersion". It has more info and using that it can be correctly detected that the user uses Firefox on Linux. Users who want to be incognito can modify these values in their browsers, so there is no workaround for such rare cases. Added "else if" statements to prevent overwriting the variable. Also, added a check that prevents to use "click" on "null" elements (in case if OS haven't been detected or an element doesn't exist in DOM). Fixes golang/go#41537 Fixes golang/go#41528 Change-Id: Iab94801008eddc17c039d49c19c98bef7641afeb GitHub-Last-Rev: 6b891e9 GitHub-Pull-Request: #17 Reviewed-on: https://go-review.googlesource.com/c/website/+/256318 Reviewed-by: Dmitri Shuralyov <email@example.com> Reviewed-by: Steve Traut <firstname.lastname@example.org> Run-TryBot: Dmitri Shuralyov <email@example.com> TryBot-Result: Go Bot <firstname.lastname@example.org> Trust: Dmitri Shuralyov <email@example.com>