Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regexp: fix 64-bit performance regression #4153

Closed
rsc opened this issue Sep 25, 2012 · 4 comments
Closed

regexp: fix 64-bit performance regression #4153

rsc opened this issue Sep 25, 2012 · 4 comments
Assignees
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Sep 25, 2012

The regexpdna benchmark in the shootout is significantly slower with the new 64-bit ints
on amd64. Look into this. The most likely cause is extra memory use and thus extra
garbage collection. The bulk of the regexp memory is already marked int32, though.

A nice thing to do as Go 1.1 is wrapping up.
@remyoudompheng
Copy link
Contributor

@remyoudompheng remyoudompheng commented Nov 3, 2012

Comment 1:

Was it fixed by http://golang.org/cl/6821052 ?
@rsc
Copy link
Contributor Author

@rsc rsc commented Nov 6, 2012

Comment 2:

Want to run regexpdna to find out?  :-)
@remyoudompheng
Copy link
Contributor

@remyoudompheng remyoudompheng commented Nov 6, 2012

Comment 3:

regex-dna 100000
GCC:
    gcc -m64 -O2 regex-dna.c -lpcre 0.48u 0.00s 0.49r
Go 1.0.3:
    gc regex-dna    3.23u 0.01s 3.25r
Go rev e0a3e88ff2ae (before switch to 64-bit ints)
    gc regex-dna    3.27u 0.00s 3.28r
Go rev 5bc48b616305 (before componentgen fix)
    gc regex-dna    4.39u 0.01s 4.41r
Go tip:
    gc regex-dna    3.21u 0.01s 3.22r
@rsc
Copy link
Contributor Author

@rsc rsc commented Nov 7, 2012

Comment 4:

Thanks for the fix!

Status changed to Fixed.

@rsc rsc added fixed labels Nov 7, 2012
@rsc rsc self-assigned this Nov 7, 2012
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.