Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: show more than 10 results per page #41594

seankhliao opened this issue Sep 23, 2020 · 1 comment

x/pkgsite: show more than 10 results per page #41594

seankhliao opened this issue Sep 23, 2020 · 1 comment


Copy link

@seankhliao seankhliao commented Sep 23, 2020

What is the URL of the page with the issue?

The search results page, ex:

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 Safari/537.36



What did you do?

Perform a search

What did you expect to see?

Option to (permanently?) show more than 10 results per page

What did you see instead?

results fixed at 10 per page

This is more of an issue for when there aren't well established/overwhelmingly popular libraries, or when the search is for something generic, where browsing through a longer page results would make the discovery process easier.

Copy link

@MistaTwista MistaTwista commented Oct 4, 2020

There is a limit query param, to do what you need, currently its max value is 100, example (in code it's there internal/frontend/search.go:123)

I can implement this feature at frontend, I think it should be somewhere here content/static/html/pages/search.tmpl or there content/static/html/helpers/_pagination.tmpl

"Because we are currently working on design updates to, we will not be accepting any contributions for issues with a UX label." looks like this issue will take UX label...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants