Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: document GO_DISCOVERY_CONFIG_BUCKET and GO_DISCOVERY_CONFIG_DYNAMIC #41608

Closed
iangudger opened this issue Sep 24, 2020 · 3 comments
Closed
Assignees
Labels

Comments

@iangudger
Copy link
Contributor

@iangudger iangudger commented Sep 24, 2020

04ec3b7c0d964e125da87276a683769bc392f561 added GO_DISCOVERY_CONFIG_BUCKET and GO_DISCOVERY_CONFIG_DYNAMIC and made them required. The frontend binary for example will no longer run without these new environment variables set. Acceptable values do not seem to be documented anywhere and the development instructions in doc/frontend.md are now broken.

@gopherbot gopherbot added the pkgsite label Sep 24, 2020
@gopherbot gopherbot added this to the Unreleased milestone Sep 24, 2020
@iangudger
Copy link
Contributor Author

@iangudger iangudger commented Sep 24, 2020

CC @jba

@jba jba self-assigned this Sep 24, 2020
@jba
Copy link
Contributor

@jba jba commented Sep 24, 2020

Sorry about that. If you have a GCS bucket you can create an empty file there and set the variables to the bucket and file name, respectively. I'll arrange for an alternative that doesn't require GCS.

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 24, 2020

Change https://golang.org/cl/257098 mentions this issue: internal/config: support dynamic config from a file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants