crypto/x509: windows test exe crashes while calling syscall.CertGetCertificateChain during TestSystemVerify

[gopherbot]

by raul.san@sent.com:

Can not compile go1.0.3 on Windows XP, 64 bits

ok      crypto/tls      0.153s
exit status 128
FAIL    crypto/x509     0.551s
?       crypto/x509/pkix        [no test files]

Note: I had also the same failure at go1.0.2

[alexbrainman]

Comment 1:

Very little details. Perhaps, you could investigate more. Maybe run tests in
crypto/x509, with "-v" ?
Thank you.
Alex

Status changed to WaitingForReply.

[gopherbot]

Comment 2 by raul.san@sent.com:

C:\go-src\src\pkg\crypto\x509>go test -v
=== RUN TestPKCS8
--- PASS: TestPKCS8 (0.05 seconds)
=== RUN TestGoVerify
--- PASS: TestGoVerify (0.02 seconds)
=== RUN TestSystemVerify
exit status 128
FAIL    _/C_/go-src/src/pkg/crypto/x509 0.453s

[alexbrainman]

Comment 3:

Still do not see what is happening here. I take it, TestSystemVerify fails. Does it?
Perhaps, you could put some prints in the test to see how far it gets. Thank you.
Alex

[gopherbot]

Comment 4 by raul.san@sent.com:

I though that the error would be reproducible to another people. I'm using Windows XP 64
bits like guest in VirtualBox under Ubuntu.

[alexbrainman]

Comment 5:

I can't reproduce it here. Many different systems. Virtual and not. None of those is
VirtualBox.
But don't let it discourage you from bug hunting. Thank you.
Alex

[gopherbot]

Comment 6 by raul.san@sent.com:

The error is produced after of:
http://golang.org/src/pkg/crypto/x509/verify_test.go#L187
So I, added:
  println("ok")
  chains, err := leaf.Verify(opts)
  fmt.Println("i:", i, "ERR:", err)
and I commented function TestGoVerify since it calls to testVerify() too
and this is the output:
=== RUN TestSystemVerify
ok
exit status 128
* * *
Like you can see, it exits directly ar running that function: leaf.Verify(opts)

[gopherbot]

Comment 7 by raul.san@sent.com:

The failure is here:
http://golang.org/src/pkg/crypto/x509/verify.go#L157
I added:
    println("FOO")
    if opts.Roots == nil && runtime.GOOS == "windows" {
        return c.systemVerify(&opts)
    }
    println("BAR")
and the output is:
FOO
exit status 128
* * *
I hope it helps, tell me if I can help in some more

[minux]

Comment 8:

it seems the code abnormally exits without any error messages?
if it is the case,
could you please use gdb to run x509.test can see if you can
get a backtrace and detailed reason about the exit?
Or, you can continue put printlns in systemVerify in 
http://golang.org/src/pkg/crypto/x509/root_windows.go.
NOTE: I can't reproduce this either.

[gopherbot]

Comment 9 by raul.san@sent.com:

and going back, here you have the line where it fails:
http://golang.org/src/pkg/crypto/x509/root_windows.go#L197
    err = syscall.CertGetCertificateChain(syscall.Handle(0), storeCtx, verifyTime, storeCtx.Store, para, 0, 0, &chainCtx)
* * *
It fails on this syscall.

[minux]

Comment 10:

what does err say? is it nil? or it just fails to return and immediate exits?

[gopherbot]

Comment 11 by raul.san@sent.com:

I put a println before and after of that line, and it is only showed the first one. So
it just fails at running and exit, it does not get the error.

[alexbrainman]

Comment 12:

What happens if you change one line:
# hg diff root_windows.go
diff -r d04dcbbb5f91 src/pkg/crypto/x509/root_windows.go
--- a/src/pkg/crypto/x509/root_windows.go       Sat Sep 29 12:43:05 2012 +0900
+++ b/src/pkg/crypto/x509/root_windows.go       Sun Sep 30 00:26:11 2012 +1000
@@ -154,7 +154,7 @@
        // If there's a DNSName set in opts, assume we're verifying
        // a certificate from a TLS server.
-       if hasDNSName {
+       if false {
                oids := []*byte{
                        &syscall.OID_PKIX_KP_SERVER_AUTH[0],
                        // Both IE and Chrome allow certificates with
#
I am running this version:
# hg id 
d04dcbbb5f91+ tip
Thank you.
Alex

[gopherbot]

Comment 13 by raul.san@sent.com:

Nothing, the same failure.

[alexbrainman]

Comment 14:

I do not know what else to suggest. But I will accept this issue for now.
Alex

Status changed to Accepted.

[rsc]

Comment 16:

Labels changed: added go1.1.