Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: document that the GCM AEADs are safe for concurrent use if the underlying cipher.Block is #41689

Open
cespare opened this issue Sep 29, 2020 · 1 comment

Comments

@cespare
Copy link
Contributor

@cespare cespare commented Sep 29, 2020

This is a follow-on to #25882.

That issue is about documenting which cipher.Block implementations are safe for concurrent use.

Similarly, the cipher.AEAD created by NewGCM and friends ought to be documented as safe for concurrent use if the underlying cipher.Block is. In particular, AES-GCM should be safe.

/cc @FiloSottile

@FiloSottile
Copy link
Contributor

@FiloSottile FiloSottile commented Sep 29, 2020

Sounds good, send a CL with a test if you'd like! Thank you!

@andybons andybons added this to the Unplanned milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants