Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: add unit tests for snapshot.clone #41719

Open
stamblerre opened this issue Sep 30, 2020 · 1 comment
Open

x/tools/gopls: add unit tests for snapshot.clone #41719

stamblerre opened this issue Sep 30, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Sep 30, 2020

It could also probably benefit from being refactored -- it is getting very long and complicated.

See https://golang.org/cl/258121.

@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Sep 30, 2020
@stamblerre stamblerre self-assigned this Oct 7, 2020
@stamblerre stamblerre added this to Needs Triage in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Needs Triage to Non-critical in vscode-go: gopls by default Nov 10, 2020
@stamblerre stamblerre moved this from Non-critical to Testing in vscode-go: gopls by default Nov 10, 2020
@findleyr
Copy link
Contributor

@findleyr findleyr commented Nov 11, 2020

In https://golang.org/cl/261237, I factored out some of the cloning logic into cache/workspace.go, which has unit tests. We could probably carve it up a bit more though.

@stamblerre stamblerre removed this from Testing in vscode-go: gopls by default Dec 15, 2020
@stamblerre stamblerre added this to Documentation in vscode-go: gopls by default Dec 16, 2020
@stamblerre stamblerre moved this from Documentation to Testing in vscode-go: gopls by default Dec 16, 2020
@stamblerre stamblerre removed this from Testing in vscode-go: gopls by default Jan 14, 2021
@stamblerre stamblerre added this to To Do in gopls: v1.0.0 Feb 28, 2021
@stamblerre stamblerre removed their assignment Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants