x/build: apply Hold+1 to any CL with mismatch between target branch and subject prefix #41722
Labels
Builders
x/build issues (builders, bots, dashboards)
FeatureRequest
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
When working on branches other than the main one, or making cherry-pick CLs, we have a convention of putting the branch name in square brackets before the subject.
From https://golang.org/wiki/MinorReleases:
If there is a mismatch between the actual target branch of the CL and what the prefix says, we should have some automated mechanism to prevent accidental submission.
This could've helped catch:
Perhaps it can be implemented as gopherbot applying a -2 code review vote (and a comment?), or some other way. This is closely related to #10658, which is about detecting large binaries, and to #18548, which is about various server-side checks.
/cc @golang/osp-team @cherrymui @jeremyfaller
The text was updated successfully, but these errors were encountered: