Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: -2 any CL with mismatch between target branch and subject prefix #41722
When working on branches other than the main one, or making cherry-pick CLs, we have a convention of putting the branch name in square brackets before the subject.
If there is a mismatch between the actual target branch of the CL and what the prefix says, we should have some automated mechanism to prevent accidental submission.
This could've helped catch #41718, where the CL subject correctly indicated the intended branch as "[dev.link]".
Perhaps it can be implemented as gopherbot applying a -2 code review vote (and a comment?), or some other way. This is closely related to #10658, which is about detecting large binaries, and to #18548, which is about various server-side checks.