Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: apply Hold+1 to any CL with mismatch between target branch and subject prefix #41722

Open
dmitshur opened this issue Sep 30, 2020 · 0 comments
Labels
Builders FeatureRequest NeedsInvestigation
Milestone

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Sep 30, 2020

When working on branches other than the main one, or making cherry-pick CLs, we have a convention of putting the branch name in square brackets before the subject.

From https://golang.org/wiki/MinorReleases:

The cherry-pick CL must include a message prefix like [release-branch.go1.10]

If there is a mismatch between the actual target branch of the CL and what the prefix says, we should have some automated mechanism to prevent accidental submission.

This could've helped catch:

Perhaps it can be implemented as gopherbot applying a -2 code review vote (and a comment?), or some other way. This is closely related to #10658, which is about detecting large binaries, and to #18548, which is about various server-side checks.

/cc @golang/osp-team @cherrymui @jeremyfaller

@dmitshur dmitshur added NeedsInvestigation FeatureRequest labels Sep 30, 2020
@dmitshur dmitshur added this to the Unreleased milestone Sep 30, 2020
@gopherbot gopherbot added the Builders label Sep 30, 2020
@dmitshur dmitshur changed the title x/build: -2 any CL with mismatch between target branch and subject prefix x/build: apply Hold+1 to any CL with mismatch between target branch and subject prefix May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders FeatureRequest NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

2 participants