Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: windows install step adding install dir to PATH not always working #41762

Open
oddlittlebird opened this issue Oct 2, 2020 · 5 comments
Open

x/website: windows install step adding install dir to PATH not always working #41762

oddlittlebird opened this issue Oct 2, 2020 · 5 comments
Labels
NeedsInvestigation OS-Windows
Milestone
Unreleased

Comments

@oddlittlebird
Copy link

@oddlittlebird oddlittlebird commented Oct 2, 2020

Error on page https://golang.org/doc/tutorial/compile-install

In step 3, the Windows command needs double quotes around the path to work.

image
@gopherbot gopherbot added this to the Unreleased milestone Oct 2, 2020
@ALTree ALTree changed the title x/website: x/website: windows install step adding install dir to PATH not always working Oct 3, 2020
@networkimprov
Copy link

@networkimprov networkimprov commented Oct 4, 2020

You're using PowerShell; the instructions are for Command shell. Should it give separate instructions for PowerShell? The PS way to revise path is:

$env:Path += ";C:\Program Files\xyz\bin"

@oddlittlebird
Copy link
Author

@oddlittlebird oddlittlebird commented Oct 5, 2020

Either give separate instructions or make very clear to Windows users which terminal they should use.

@networkimprov
Copy link

@networkimprov networkimprov commented Oct 5, 2020

@julieqiu are you the right cc for this?

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Oct 5, 2020

/cc @dmitshur per owners

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Oct 5, 2020

Also /cc @stevetraut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation OS-Windows
Projects
None yet
Milestone
Unreleased
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@networkimprov @dmitshur @ALTree @julieqiu @gopherbot @oddlittlebird