Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/dashboard: only run linux-386-387 builder on Go 1.15 and older #41799

Closed
dmitshur opened this issue Oct 5, 2020 · 4 comments
Closed
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Oct 5, 2020

The linux-386-387 builder has started to fail since CL 258957.

Support for GO386=387 is being dropped in Go 1.16, so the builder can be deleted.

Edit: It shouldn't be outright deleted, it should provide coverage for Go 1.15 and 1.14 where it's still supported. Thank you @bcmills for spotting this.

/cc @cagedmantis @toothrot @randall77

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Oct 5, 2020
@dmitshur dmitshur self-assigned this Oct 5, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 5, 2020
@dmitshur dmitshur changed the title x/build: remove linux-386-387 builder x/build/dashboard: remove linux-386-387 builder Oct 5, 2020
@randall77
Copy link
Contributor

Is this just https://go-review.googlesource.com/c/go/+/257963/ , or is there more to do?

@gopherbot
Copy link

Change https://golang.org/cl/259449 mentions this issue: dashboard: remove linux-386-387 builder

@dmitshur
Copy link
Contributor Author

dmitshur commented Oct 5, 2020

@randall77 It's also CL 259449.

@dmitshur dmitshur changed the title x/build/dashboard: remove linux-386-387 builder x/build/dashboard: only run linux-386-387 builder on Go 1.15 and older Oct 5, 2020
@gopherbot
Copy link

Change https://golang.org/cl/342895 mentions this issue: dashboard, cmd/gomote: remove the linux-386-387 builder

gopherbot pushed a commit to golang/build that referenced this issue Aug 17, 2021
The linux-386-387 was only in use for Go 1.15 development. It is being
removed as there is no further development for Go 1.15.

For golang/go#40255
For golang/go#41799

Change-Id: If636c0099bce195e227a5036842ace92e8305fc9
Reviewed-on: https://go-review.googlesource.com/c/build/+/342895
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants