Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: change GetNestedModules to return nested modules for series #41802

Closed
julieqiu opened this issue Oct 5, 2020 · 3 comments
Closed

x/pkgsite: change GetNestedModules to return nested modules for series #41802

julieqiu opened this issue Oct 5, 2020 · 3 comments
Labels
NeedsFix help wanted pkgsite
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Oct 5, 2020

At the moment, GetNestedModules figures out which nested modules to return using the module_path. However, this means that modules will not be returned when the major version is v2 or higher.

For example, GetNestedModules(ctx, "golang.org/x/tools/v2") will not return golang.org/x/tools/gopls and it should.
@julieqiu julieqiu added pkgsite NeedsFix labels Oct 5, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 5, 2020
@julieqiu julieqiu modified the milestones: Unreleased, gopls/v0.5.1, pkgsite/unplanned Oct 5, 2020
@julieqiu julieqiu added the help wanted label Oct 5, 2020
@trongbq
Copy link

@trongbq trongbq commented Oct 6, 2020

@julieqiu I will work on this one.
@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Oct 6, 2020

Thanks, @trongbq!
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2020

Change https://golang.org/cl/260277 mentions this issue: internal/postgres/details: GetNestedModules supports input paths which have major version
@gopherbot gopherbot closed this in golang/pkgsite@73cb253 Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix help wanted pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@julieqiu @trongbq @gopherbot