Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: infer workspace modules from a user-provided gopls.mod #41837

Open
stamblerre opened this issue Oct 7, 2020 · 1 comment
Open

x/tools/gopls: infer workspace modules from a user-provided gopls.mod #41837

stamblerre opened this issue Oct 7, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Oct 7, 2020

Tracking issue for the work @findleyr has been doing on the user-provided gopls.mod file, which can be used to override gopls's automatically created workspace module.

The remaining tasks are:

  • Do not search for workspace modules in the presence of a gopls.mod, and instead populate the modules map by looking at the gopls.mod's requires.
  • Handle on-disk modifications to the gopls.mod
  • Detecting a gopls.mod: We should look "upwards" for a go.mod or a gopls.mod, stopping at the first gopls.mod. The gopls.mod always beats the go.mod.
@gopherbot gopherbot added this to the Unreleased milestone Oct 7, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Oct 7, 2020
@stamblerre stamblerre added this to Critical in gopls/v1.0.0 Oct 12, 2020
@stamblerre stamblerre moved this from Critical to Assigned in gopls/v1.0.0 Oct 12, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 16, 2020

Change https://golang.org/cl/261237 mentions this issue: internal/lsp/cache: introduce a workspaceModule abstraction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.