Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: plan for vendoring in multi-module workspaces #41838

Open
stamblerre opened this issue Oct 7, 2020 · 0 comments
Open

x/tools/gopls: plan for vendoring in multi-module workspaces #41838

stamblerre opened this issue Oct 7, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Oct 7, 2020

As previously discussed, we have not yet accounted for modules that use vendoring in the workspace module design. As of https://golang.org/cl/259623, the workspace module will be enabled for modules that have vendor directories, but the vendor directories will be ignored.

@heschik investigated the possibility of creating a workspace module vendor directory by combining the vendor directories of all of the modules in the workspace, but this doesn't seem to be a feasible approach.

If we choose to simply ignore vendor directories, we must first resolve #41819. We might also consider using the default mode if we only detect one module in the workspace, as the workspace module will offer no advantage in that case.

@gopherbot gopherbot added this to the Unreleased milestone Oct 7, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Oct 7, 2020
@stamblerre stamblerre added this to Critical in gopls/v1.0.0 Oct 12, 2020
@stamblerre stamblerre moved this from Critical to Assigned in gopls/v1.0.0 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.