Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: implement GO386=softfloat #41848

Closed
dmitshur opened this issue Oct 7, 2020 · 2 comments
Closed

all: implement GO386=softfloat #41848

dmitshur opened this issue Oct 7, 2020 · 2 comments
Labels
Milestone

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 7, 2020

This was implemented in CL 260017. Making an issue retroactively for tracking purposes.

/cc @randall77 @cagedmantis @toothrot

@dmitshur dmitshur added the NeedsFix label Oct 7, 2020
@dmitshur dmitshur added this to the Go1.16 milestone Oct 7, 2020
@dmitshur dmitshur closed this Oct 7, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2020

Change https://golang.org/cl/260201 mentions this issue: dashboard: add linux-386-softfloat builder

gopherbot pushed a commit to golang/build that referenced this issue Oct 8, 2020
It's based on the linux-386-387 builder, but with GO386=softfloat
and Debian 9 (stretch) instead of Debian 8 (jessie).

Test it on a subset of golang.org/x repos (golang.org/x/crypto),
since that should provide sufficient test coverage.

For golang/go#41840.
For golang/go#41848.

Change-Id: Ida95fce198056a05c359ac5ab816c582bdd5930f
Reviewed-on: https://go-review.googlesource.com/c/build/+/260201
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 9, 2020

Change https://golang.org/cl/261097 mentions this issue: dashboard: remove known issue for GO386=softfloat builder

gopherbot pushed a commit to golang/build that referenced this issue Oct 12, 2020
The builder is producing expected results.

Fixes golang/go#41840.
For golang/go#41848.

Change-Id: I08de0457b5ead7ac5dcc15edb95517f0f3e377fe
Reviewed-on: https://go-review.googlesource.com/c/build/+/261097
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.