Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/relnote: RELNOTE in Gerrit comments are missed after Gerrit UI change in July 2020 #41849

Open
dmitshur opened this issue Oct 7, 2020 · 1 comment

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 7, 2020

Similarly to #40106, another effect of the Gerrit UI switch from change messages to patchset comments is that that when "RELNOTE=yes" is posted in a comment (rather than in the commit message), it is not picked up by the relnote command today.

For example, CL 258957 has a comment that contains "RELNOTES=yes", yet it's not picked up by relnote.

Unlike #40106, relnote uses maintner to very quickly scan over all CLs covering a time period of 6 months rather than the Gerrit API, so the fix is not going to be as straightforward. There are different paths that come to mind:

  • Support for inline comments can be added to the maintner data model. This is already tracked in #24863. (It may have a significant effect on the amount of data being recorded, but measurements haven't been done yet. Also see #37603.)

  • Another option is to modify relnote to use the Gerrit API. It should be possible to write a search query to find the relevant CLs. If such a search query is possible, this might be a much smaller volume of work.

  • Find an effective replacement for the x/build/cmd/relnote command and delete it.

/cc @cagedmantis @toothrot

@dmitshur dmitshur added this to the Go1.16 milestone Oct 7, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 7, 2020

Change https://golang.org/cl/260337 mentions this issue: doc/go1.16: document removal of GO386=387

gopherbot pushed a commit that referenced this issue Oct 7, 2020
Also add a few more TODOs as found by the relnote command.
It's an incomplete list due to #41849.

For #40700.

Change-Id: Id17a9be86d3338e1fcb281d26e7298ff26e92864
Reviewed-on: https://go-review.googlesource.com/c/go/+/260337
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.