x/pkgsite: clarify definitions of version in internal/frontend #41855
Milestone
Comments
Change https://golang.org/cl/264859 mentions this issue: |
gopherbot
pushed a commit
to golang/pkgsite
that referenced
this issue
Oct 28, 2020
For standard library URLs, use the path with the "go" form of the version, rather than the "v" form. (Outside of stdlib, the two should be the same.) As part of the fix, define and test the functions that create both ordinary and canonical URL paths for units. For golang/go#41855 Change-Id: I5502c4792c4edada6579e483b214394d11c23351 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/264859 Trust: Jonathan Amsterdam <jba@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Julie Qiu <julie@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are several definitions of version in internal/frontend:
These different cases should be clearly documented and tested, to avoid issues such as #41850.
The text was updated successfully, but these errors were encountered: