Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: clarify definitions of version in internal/frontend #41855

Open
julieqiu opened this issue Oct 7, 2020 · 1 comment
Open

x/pkgsite: clarify definitions of version in internal/frontend #41855

julieqiu opened this issue Oct 7, 2020 · 1 comment
Labels
NeedsFix pkgsite
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Oct 7, 2020

There are several definitions of version in internal/frontend:

These different cases should be clearly documented and tested, to avoid issues such as #41850.
@julieqiu julieqiu added NeedsFix pkgsite labels Oct 7, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 7, 2020
@jba jba removed this from the Unreleased milestone Oct 8, 2020
@jba jba added this to the pkgsite/unplanned milestone Oct 8, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 27, 2020

Change https://golang.org/cl/264859 mentions this issue: content/static/html: use "go" versions for stdlib links in units

gopherbot pushed a commit to golang/pkgsite that referenced this issue Oct 28, 2020
@jba
content/static/html: use "go" versions for stdlib links in units
9ab53d6 
For standard library URLs, use the path with the "go" form of the
version, rather than the "v" form. (Outside of stdlib, the two should
be the same.)

As part of the fix, define and test the functions that create
both ordinary and canonical URL paths for units.

For golang/go#41855

Change-Id: I5502c4792c4edada6579e483b214394d11c23351
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/264859
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix pkgsite
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
3 participants
@julieqiu @gopherbot @jba