-
Notifications
You must be signed in to change notification settings - Fork 18k
x/website: widen "Download" button on /doc/install page so text doesn't wrap excessively #41856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
can you show a screenshot? are you using font scaling? because it looks fine (single line) for |
This is what https://golang.org/doc/install looks like at 100% scaling in Chrome on macOS for me: With the suggested 16rem width: Making it wider on the https://golang.org/doc/install page seems fine. We should take care that it doesn't affect other pages inadvertently (e.g., https://golang.org/dl/ also has buttons with the "download" class). |
The .download width style rule on https://golang.org/dl/ appears to be superseded by the .downloadBox width, which is set to 280px. I suggest we change .download width to 17.5rem, which is equivalent to 280px. That will make the buttons on both pages the same width. Just in case. |
Change https://golang.org/cl/260917 mentions this issue: |
This change sets the width style rule for download buttons so that label text in the button won't wrap excessively. This should make it a little easier to read. Fixes golang/go#41856 Change-Id: Icde39c68b10416963c9c1b493303818728488341 Reviewed-on: https://go-review.googlesource.com/c/website/+/260917 TryBot-Result: Go Bot <gobot@golang.org> Trust: Steve Traut <straut@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This is an issue requesting a change to documentation.
In the download button at https://golang.org/doc/install, the button text wraps, making it a little harder to read. Widening it a bit will give us two lines of unwrapped text for all three OSes.
Looks like changing the width value in the download class will work. It's currently 9.375rem -- it could be 16rem.
@rsc @dmitshur
The text was updated successfully, but these errors were encountered: